Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the "infamous triplet" and exports default and names exports in TypeScript types #282

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

fox1t
Copy link
Member

@fox1t fox1t commented Aug 10, 2020

This PR is the result of the ongoing talks about supporting all import contexts for the fastify ecosystem. We can use it as a case study for other core plugins.

What is important to note is that it is not enough to add this code only at JS, since the exported typings need to be updated too.

  • Adds the "infamous triplet" in module.exports
  • Replaces namespace export with "infamous triplet" in TypeScript typings
  • Adds test for all TS imports
  • Adds test for ESM context

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ca304cf into fastify:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants