refactor: change reply.redirect() signature

[gurgunday]

Note: should consider refactoring the argument order for redirect. statusCode is optional so it should be after the required url param

Whoever put it, I agree with this note, it's a good long term change that makes the redirect method's parameters monomorphic, so it could make it faster as well

Since it would immediately break all .redirect() usage after upgrading, I opted to deprecate it for Fastify v5 with the eventual goal of fully removing the old signature in Fastify v6

Or alternatively, we can fast track this to v4 and deprecate now to aim for a v5 change, I actually prefer this one but understand it may not be appropriate for larger codebases

[gurgunday]

@mcollina what do you think? Can we make the final change in v5 or should we only deprecate the old signature for now?

[mcollina]

lgtm

(I think we could even backport it to v4, as we do deprecations in the active line here).

[Eomm]

Or alternatively, we can fast track this to v4 and deprecate now to aim for a v5 change, I actually prefer this one but understand it may not be appropriate for larger codebases

+1 on deprecating it in v4 and change it in v5.

[gurgunday]

Alright!

I'll backport it