Skip to content

Improve template card UI and functionality #1157

Merged
yujonglee merged 3 commits intomainfrom
improve-template-card-ui-and-functionality
Jul 21, 2025
Merged

Improve template card UI and functionality #1157
yujonglee merged 3 commits intomainfrom
improve-template-card-ui-and-functionality

Conversation

@ComputelessComputer
Copy link
Collaborator

  • Replaced the "Edit" and "Eye" icons with a "Check" icon to indicate the selected/default template.
  • Moved the "Set as default" functionality to a separate button, making it more prominent and easier to use.
  • Removed the logic to check if a template is built-in, as this information is no longer needed for the updated UI.
  • Updated the handleCardClick function to call the onEdit callback instead of onSelect, providing a more intuitive user experience.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

📝 Walkthrough

Walkthrough

The changes update the TemplateCard component's UI logic, swapping the roles of card and button clicks for editing and setting default templates. Localization files for English and Korean are also updated, adjusting source code references and toggling the activation status of certain messages without altering translations.

Changes

File(s) Change Summary
apps/desktop/src/components/settings/views/templates.tsx Refactored TemplateCard click logic: card now triggers edit, button sets default; simplified button rendering and icons.
apps/desktop/src/locales/en/messages.po,
apps/desktop/src/locales/ko/messages.po
Updated source references for messages, toggled active/commented status for some entries; no translation changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TemplateCard
    participant ParentComponent

    User->>TemplateCard: Clicks card
    TemplateCard->>ParentComponent: Calls onEdit() if defined

    User->>TemplateCard: Clicks "Set as default" button
    TemplateCard->>ParentComponent: Calls onSelect()
Loading

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a046bef and 316cf9b.

📒 Files selected for processing (3)
  • apps/desktop/src/components/settings/views/templates.tsx (3 hunks)
  • apps/desktop/src/locales/en/messages.po (3 hunks)
  • apps/desktop/src/locales/ko/messages.po (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/desktop/src/components/settings/views/templates.tsx
  • apps/desktop/src/locales/ko/messages.po
  • apps/desktop/src/locales/en/messages.po
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ComputelessComputer ComputelessComputer changed the title feat(templates): Improve template card UI and functionality Improve template card UI and functionality Jul 15, 2025
The changes made in this commit improve the user interface and functionality of the template card component in the desktop application. The key changes are:

- Replaced the "Edit" and "Eye" icons with a "Check" icon to indicate the selected/default template.
- Moved the "Set as default" functionality to a separate button, making it more prominent and easier to use.
- Removed the logic to check if a template is built-in, as this information is no longer needed for the updated UI.
- Updated the `handleCardClick` function to call the `onEdit` callback instead of `onSelect`, providing a more intuitive user experience.

These changes aim to enhance the overall usability and clarity of the template management feature in the desktop application.
@ComputelessComputer ComputelessComputer force-pushed the improve-template-card-ui-and-functionality branch from a046bef to 316cf9b Compare July 15, 2025 09:23
@yujonglee yujonglee merged commit 3c786f0 into main Jul 21, 2025
5 of 6 checks passed
@yujonglee yujonglee deleted the improve-template-card-ui-and-functionality branch July 21, 2025 16:06
@coderabbitai coderabbitai bot mentioned this pull request Oct 4, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments