Skip to content

Improve template card UI and functionality #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yujonglee merged 3 commits into from
Jul 21, 2025
Merged

Improve template card UI and functionality #1157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f99730
feat(templates): Improve template card UI and functionality
ComputelessComputer Jul 15, 2025
316cf9b
i18n
ComputelessComputer Jul 15, 2025
6815d5f
i18n
yujonglee Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions apps/desktop/src/components/settings/views/templates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Button } from "@hypr/ui/components/ui/button";
import { cn } from "@hypr/ui/lib/utils";
import { Trans } from "@lingui/react/macro";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { ArrowLeftIcon, EditIcon, EyeIcon, Loader2Icon, PlusIcon } from "lucide-react";
import { ArrowLeftIcon, CheckIcon, Loader2Icon, PlusIcon } from "lucide-react";
import { useEffect, useState } from "react";
import TemplateEditor from "./template";

Expand Down Expand Up @@ -353,12 +353,12 @@ function TemplateCard({ template, onSelect, onEdit, onClone, onDelete, emoji, is
};

const handleCardClick = () => {
onSelect();
onEdit?.();
};

const handleEditClick = (e: React.MouseEvent) => {
const handleSetDefaultClick = (e: React.MouseEvent) => {
e.stopPropagation();
onEdit?.();
onSelect();
};

// Function to truncate text
Expand All @@ -369,9 +369,6 @@ function TemplateCard({ template, onSelect, onEdit, onClone, onDelete, emoji, is
return text.substring(0, maxLength).trim() + "...";
};

// Check if this is a built-in template
const isBuiltinTemplate = !TemplateService.canEditTemplate(template.id);

return (
<div
className={cn(
Expand Down Expand Up @@ -401,16 +398,15 @@ function TemplateCard({ template, onSelect, onEdit, onClone, onDelete, emoji, is
</div>
</div>

{onEdit && (
<Button
variant="outline"
size="sm"
onClick={handleEditClick}
className="ml-2 rounded-lg border-neutral-300 hover:border-neutral-400"
>
{isBuiltinTemplate ? <EyeIcon className="h-4 w-4" /> : <EditIcon className="h-4 w-4" />}
</Button>
)}
<Button
variant="outline"
size="sm"
onClick={handleSetDefaultClick}
className="text-xs text-neutral-600 hover:text-neutral-900 px-2 py-1 h-auto flex items-center gap-1 min-w-[96px]"
>
{isSelected && <CheckIcon className="h-3 w-3" />}
{isSelected ? "Default" : "Set as default"}
</Button>
</div>
</div>
);
Expand Down
Loading