Add pinning functionality for tabs#2361
Merged
ComputelessComputer merged 5 commits intomainfrom Dec 29, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
ComputelessComputer
changed the title
ComputelessComputer
force-pushed
the
feat/tab-close-button
branch
3 times, most recently
from
24c2ef8 to
ffeeeb7
Compare
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
ComputelessComputer
force-pushed
the
feat/add-pinned-tabs-functionality
branch
from
1a7dd04 to
1d8b490
Compare
feat(sessions): add spinner forancing and finalizing states feat(tabs): add pinned property to tab schema feat(tabs): add pin and unpin functionality for tabs feat): add pinned property to tab types (tabs): add pin functionality to tabs feat(tabs): add pinning functionality to tabs feat(tabs): cmd+w unpins pinned tabs instead of closing (#2445) - Modified cmd+w handler to check if current tab is pinned - If pinned, unpin the tab instead of closing it - Made pin icon clickable to unpin tabs Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: john@hyprnote.com <john@hyprnote.com> fix(ui): resolve merge conflicts and duplicate imports refactor: simplify tab components and context menu
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Remove unnecessary ternary root and trailing undefined assignment for contextMenu in shared.tsx. This makes the code clearer by assigning the menu array directly when selected and not empty, and otherwise assigning an empty array, avoiding an explicit undefined branch. The change prevents mixing array/undefined types and simplifies readability and control flow for context menu construction.
Ensure the tab context menu shows "Close" and pin/unpin options when a tab is active or selected, and shows the full set (Close, Close others, Close all, pin/unpin) for non-active tabs. This fixes inconsistent behavior where the active tab would not present pin/unpin alongside Close, aligning the active tab menu with the intended UX and restoring pin/unpin availability where appropriate.
Add a separator entry between pin/unpin and other menu items in desktop context menus to improve visual grouping. The change extends the MenuItemDef type to accept a separator variant and uses PredefinedMenuItem.Separator when mapping items to native menu entries. This ensures separators are correctly created for both single-tab and multi-tab context menus.
ComputelessComputer
force-pushed
the
feat/add-pinned-tabs-functionality
branch
from
1a78f2a to
0462d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the current tab in view is "pinned", it will not be replaced when trying to open other views