feat(tabs): cmd+w unpins pinned tabs instead of closing by devin-ai-integration[bot] · Pull Request #2445 · fastrepl/char

devin-ai-integration · 2025-12-20T13:00:28Z

feat(tabs): cmd+w unpins pinned tabs instead of closing

Summary

This PR adds two ways to unpin pinned tabs:

Keyboard shortcut: Pressing cmd+w on a pinned tab now unpins it instead of closing it
Click interaction: The pin icon on pinned tabs is now clickable and unpins the tab when clicked

This stacks on top of #2361 which adds the base pinned tabs functionality.

Review & Testing Checklist for Human

Verify the unpin action from the tabs store works correctly (this PR assumes it exists from Add pinning functionality for tabs #2361)
Test cmd+w on a pinned tab - should unpin, not close
Test cmd+w on a regular unpinned tab - should close as before
Test clicking the pin icon on a pinned tab - should unpin
Verify hover states on the pin icon button look correct

Recommended test plan:

Open the desktop app
Create multiple tabs
Pin a tab via right-click context menu
Press cmd+w on the pinned tab → verify it unpins (not closes)
Pin it again, then click the pin icon → verify it unpins
On an unpinned tab, press cmd+w → verify it closes normally

Notes

Important: This PR was not tested in the running desktop app due to build time constraints. TypeScript compilation passes but manual UI verification is required.

Requested by: john@hyprnote.com (@ComputelessComputer)
Link to Devin run: https://app.devin.ai/sessions/a6a46f67021e4fac92525aa788fe3b26

This is part 3 of 3 in a stack :

- Modified cmd+w handler to check if current tab is pinned - If pinned, unpin the tab instead of closing it - Made pin icon clickable to unpin tabs Co-Authored-By: john@hyprnote.com <john@hyprnote.com>

devin-ai-integration · 2025-12-20T13:00:31Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

coderabbitai · 2025-12-20T13:00:34Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

feat(sessions): add spinner forancing and finalizing states feat(tabs): add pinned property to tab schema feat(tabs): add pin and unpin functionality for tabs feat): add pinned property to tab types (tabs): add pin functionality to tabs feat(tabs): add pinning functionality to tabs feat(tabs): cmd+w unpins pinned tabs instead of closing (#2445) - Modified cmd+w handler to check if current tab is pinned - If pinned, unpin the tab instead of closing it - Made pin icon clickable to unpin tabs Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: john@hyprnote.com <john@hyprnote.com> fix(ui): resolve merge conflicts and duplicate imports refactor: simplify tab components and context menu

* feat(ui): add finalizing state to tab close button feat(sessions): add spinner forancing and finalizing states feat(tabs): add pinned property to tab schema feat(tabs): add pin and unpin functionality for tabs feat): add pinned property to tab types (tabs): add pin functionality to tabs feat(tabs): add pinning functionality to tabs feat(tabs): cmd+w unpins pinned tabs instead of closing (#2445) - Modified cmd+w handler to check if current tab is pinned - If pinned, unpin the tab instead of closing it - Made pin icon clickable to unpin tabs Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: john@hyprnote.com <john@hyprnote.com> fix(ui): resolve merge conflicts and duplicate imports refactor: simplify tab components and context menu * Update apps/desktop/src/store/zustand/tabs/basic.ts Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Simplify contextMenu assignment and maintain type consistency Remove unnecessary ternary root and trailing undefined assignment for contextMenu in shared.tsx. This makes the code clearer by assigning the menu array directly when selected and not empty, and otherwise assigning an empty array, avoiding an explicit undefined branch. The change prevents mixing array/undefined types and simplifies readability and control flow for context menu construction. * Make tab context menu behave consistently for active and other tabs Ensure the tab context menu shows "Close" and pin/unpin options when a tab is active or selected, and shows the full set (Close, Close others, Close all, pin/unpin) for non-active tabs. This fixes inconsistent behavior where the active tab would not present pin/unpin alongside Close, aligning the active tab menu with the intended UX and restoring pin/unpin availability where appropriate. * Add separators to native context menus Add a separator entry between pin/unpin and other menu items in desktop context menus to improve visual grouping. The change extends the MenuItemDef type to accept a separator variant and uses PredefinedMenuItem.Separator when mapping items to native menu entries. This ensures separators are correctly created for both single-tab and multi-tab context menus. --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

feat(tabs): cmd+w unpins pinned tabs instead of closing

6e4e513

- Modified cmd+w handler to check if current tab is pinned - If pinned, unpin the tab instead of closing it - Made pin icon clickable to unpin tabs Co-Authored-By: john@hyprnote.com <john@hyprnote.com>

This was referenced Dec 20, 2025

Add pinning functionality for tabs #2361

Merged

show spinner in tabs or left side bar items when note is being enhanced #2359

Merged

ComputelessComputer requested a review from yujonglee December 20, 2025 13:11

yujonglee merged commit f2ba69f into feat/add-pinned-tabs-functionality Dec 21, 2025
2 of 3 checks passed

yujonglee deleted the devin/1766235497-cmdw-unpin-pinned-tabs branch December 21, 2025 02:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tabs): cmd+w unpins pinned tabs instead of closing#2445

feat(tabs): cmd+w unpins pinned tabs instead of closing#2445
yujonglee merged 1 commit intofeat/add-pinned-tabs-functionalityfrom
devin/1766235497-cmdw-unpin-pinned-tabs

devin-ai-integration bot commented Dec 20, 2025 •

edited by ComputelessComputer

Loading

Uh oh!

devin-ai-integration bot commented Dec 20, 2025

Uh oh!

coderabbitai bot commented Dec 20, 2025

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

devin-ai-integration bot commented Dec 20, 2025 • edited by ComputelessComputer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat(tabs): cmd+w unpins pinned tabs instead of closing

Summary

Review & Testing Checklist for Human

Notes

Uh oh!

devin-ai-integration bot commented Dec 20, 2025

🤖 Devin AI Engineer

Uh oh!

coderabbitai bot commented Dec 20, 2025

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration bot commented Dec 20, 2025 •

edited by ComputelessComputer

Loading