Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added share file changes #56

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

rahulpuroht
Copy link

@rahulpuroht rahulpuroht commented Oct 23, 2020

Closing #52

Still Need to check regarding test case.Do let me know if any changes required in any file

@rahulpuroht rahulpuroht requested a review from bronzdoc as a code owner October 23, 2020 19:19
@bronzdoc bronzdoc closed this Oct 28, 2020
@bronzdoc bronzdoc reopened this Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #56 into main will decrease coverage by 0.02%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   91.64%   91.61%   -0.03%     
==========================================
  Files          20       21       +1     
  Lines         323      346      +23     
==========================================
+ Hits          296      317      +21     
- Misses         27       29       +2     
Impacted Files Coverage Δ
lib/skunk/share.rb 91.66% <91.66%> (ø)
lib/skunk.rb 100.00% <100.00%> (ø)
lib/skunk/cli/commands/default.rb 100.00% <100.00%> (ø)
lib/skunk/cli/options/argv.rb 80.95% <0.00%> (-0.87%) ⬇️
lib/skunk/cli/commands/status_reporter.rb 97.43% <0.00%> (-0.24%) ⬇️
test/lib/skunk/cli/commands/compare_test.rb 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdd5bc...c6c6d6d. Read the comment docs.

@bronzdoc
Copy link
Contributor

@rahulpuroht thanks for the PR!

Could you give a look at the failures? thank you

@rahulpuroht
Copy link
Author

rahulpuroht commented Oct 28, 2020

@bronzdoc As this issue picked over pair programing with @etagwerker While working over it.In Test Mock request its showing "request code: 400" from skunk server.Can you check logs and let me know the reason.

@etagwerker
Copy link
Member

@rahulpuroht Thanks for your contribution! I had to re-arrange the code, but I can finally say that this feature is now in the main branch. 👍

@rahulpuroht
Copy link
Author

@rahulpuroht Thanks for your contribution! I had to re-arrange the code, but I can finally say that this feature is now in the main branch. 👍

Can you add this label too "hacktoberfest-accepted"

@etagwerker
Copy link
Member

@rahulpuroht Sure, done! 👍

etagwerker added a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants