Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/document share feature #61

Merged
merged 5 commits into from
Nov 19, 2020
Merged

Conversation

etagwerker
Copy link
Member

Hey,

This PR adds documentation about the SHARE feature. (See: #56)

Please check it out.

Thanks!

@etagwerker etagwerker requested a review from a team as a code owner November 17, 2020 20:40
@etagwerker etagwerker requested review from bronzdoc and removed request for a team November 17, 2020 20:40
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #61 (6c1e0f9) into main (d54ac16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          23       23           
  Lines         423      423           
=======================================
  Hits          397      397           
  Misses         26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54ac16...6c1e0f9. Read the comment docs.

Change the way we stub ENV to share the report

Also, remove old tmp/shared_report.txt before we test sharing mechanism
Also, remove \n from test expectation because reasons
@etagwerker etagwerker force-pushed the feature/document-share-feature branch from 74e2141 to 6c1e0f9 Compare November 19, 2020 02:20
@etagwerker etagwerker merged commit 27c89ed into main Nov 19, 2020
@etagwerker etagwerker deleted the feature/document-share-feature branch November 19, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants