Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch kernel functions for point masses #42

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

santisoler
Copy link
Member

The kernel functions for gravity fields of point sources were just one line functions with a lot of docstrings and their own tests. We are not using them outsides the actual gravity forward modelling functions for point masses, so it might be better to remove them. We can always restore them if we find a use case for them.

Relevant issues/PRs:

Fixes #38

The kernel functions for gravity fields of point sources were just one
line functions with a lot of docstrings and their own tests. We are not
using them outsides the actual gravity forward modelling functions for
point masses, so it might be better to remove them. We can always
restore them if we find a use case for them.
@santisoler santisoler merged commit 655305a into main Apr 25, 2023
@santisoler santisoler deleted the ditch-point-kernels branch April 25, 2023 17:55
@leouieda
Copy link
Member

Weeeeeell turns out we needed this for dipole inversions in https://github.com/compgeolab/micromag-euler-dipole/blob/main/code/micromag.py#L284 🤦🏾

Should we add this back (tests will be covered by the gravity tests) or use the gravity functions divided by G?

@santisoler
Copy link
Member Author

Haha, if they were useful, we can get them back. The only reason to remove them was that we didn't thought a use case for them. Would you like to open a PR that reverts this PR? I'll be glad if the tests are simpler.

santisoler added a commit that referenced this pull request Aug 17, 2023
leouieda pushed a commit that referenced this pull request Feb 20, 2024
Revert "Ditch kernel functions for point masses (#42)". Remove tests for
point source kernels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ditch the kernels functions for point masses
2 participants