Restore kernels for point masses #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 655305a.
The kernels are already being tested by the ones for gravity forward modelling of point masses.
|
@Souza-junior, would you like to take a look at this PR? Let me know if these changes work for you, as @leouieda pointed it out in #42. No pressure and no time limit, just do it if you feel to do so 🙂 |
|
Hey, @santisoler! I will take a look at it and give you feedback soon. |
leouieda
approved these changes
Feb 20, 2024
|
Merging this in! Thanks for doing it @santisoler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Ditch kernel functions for point masses (#42)". Remove tests for point source kernels.
Relevant issues/PRs:
Revert changes as requested in #42