-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support minisnip #1589
Support minisnip #1589
Conversation
What makes minisnip superior to ultisnips or neosnippets? Back then I've added them to add support, but I'm not sure we should support other plugins, especially new plugins those with a low userbase. I'm not against it, just trying to understand the value it'll bring. |
It's a very simple plugin which Just Works™ without too much Magic. I just personally prefer it over a large plugin written in Python etc.
That okay; I don't really care. I can reduce the PR to just some of the small improvements I made. It just seemed to me that adding this doesn't really affect much of anything. If you don't use it then you won't know it's there, and it adds pretty much zero maintenance overhead. |
True that, I was just worried that this can easily can spread to other plugins. I'm curious if we can somehow do the detection manual. I'm ok merging this btw, I'll chime more if I have something to show. |
Needs joereynolds/vim-minisnip#5 I've also changed the default for `g:go_snippet_engine` to `automatic`, which is a new value that will use the first snippet engine that's loaded. I think that's more user-friendly than expecting the user to set it. I also changed the detection method to use the variables, instead of scanning `runtimepath`. This is more efficient. Need to actually add the snippets for minisnip though.
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
========================================
Coverage ? 14.8%
========================================
Files ? 53
Lines ? 4146
Branches ? 0
========================================
Hits ? 614
Misses ? 3532
Partials ? 0
Continue to review full report at Codecov.
|
Needs joereynolds/vim-minisnip#5
I've also changed the default for
g:go_snippet_engine
toautomatic
,which is a new value that will use the first snippet engine that's
loaded. I think that's more user-friendly than expecting the user to set
it.
I also changed the detection method to use the variables, instead of
scanning
runtimepath
. This is more efficient.Need to actually add the snippets for minisnip though.