This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Support multiple directories in g:minisnip_dir #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific reason I added this is because I wanted to add support for minisnip in vim-go (it already supports ultisnips and neosnippet). However, with just a single directory I can't add the vim-go snippet directory. This converts g:minisnip_dir to a colon-separated list of paths, like the PATH environment variable. There are several ways to do this; I just chose this as the easiest and most backwards compatible way.
|
Hey, I'll review this tomorrow, thanks for the contribution! :D |
|
Thanks. No hurries :-) |
|
Looks good to me, can you mention it in the docs and give a few examples there too? |
Also fix some small typos in the documentation, and improve the `autocmd` example to be more general, as well as making sure it works only for the current buffer by using `setlocal`
|
Done! |
|
Thanks! |
|
That's a great add. Doesn't add complexity to the snippets but adds functionality to the plugin. Great job! |
arp242
added a commit
to fatih/vim-go
that referenced
this pull request
Dec 7, 2017
Supprt minisnip Needs joereynolds/vim-minisnip#5 I've also changed the default for `g:go_snippet_engine` to `automatic`, which is a new value that will use the first snippet engine that's loaded. I think that's more user-friendly than expecting the user to set it. I also changed the detection method to use the variables, instead of scanning `runtimepath`. This is more efficient.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specific reason I added this is because I wanted to add support for
minisnip in vim-go (it already supports ultisnips and neosnippet).
However, with just a single directory I can't add the vim-go snippet
directory.
This converts g:minisnip_dir to a colon-separated list of paths, like
the PATH environment variable.
There are several ways to do this; I just chose this as the easiest and
most backwards compatible way.