close the correct location list #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the correct location list is cleaned when terminal mode has no output.
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
==========================================
- Coverage 23.88% 23.88% -0.01%
==========================================
Files 57 57
Lines 4772 4773 +1
==========================================
Hits 1140 1140
- Misses 3632 3633 +1
Continue to review full report at Codecov.
|
|
Seems like this is a very common thing: I'll merge this and open another PR that provides a single public function, such as |
|
Opened PR here: #1724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the correct location list is cleaned when terminal mode has no
output.