list: make Clean() more useful #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cleaning a list, there is no need to show the list anymore. That's why we call `Window()` to invoke the close function. Remove all `Window()` calls and make Clean() more useful to avoid adding the second line. There is no single `Clean()` call independently, so it makes sense to change the meaning
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 23.88% 23.94% +0.05%
==========================================
Files 57 57
Lines 4773 4766 -7
==========================================
+ Hits 1140 1141 +1
+ Misses 3633 3625 -8
Continue to review full report at Codecov.
|
bhcleek
reviewed
Mar 20, 2018
autoload/go/list.vim
Outdated
| else | ||
| cclose | ||
| endif | ||
| endif |
There was a problem hiding this comment.
Instead of adding this block, calling go#list#Window(a:listtype) would reduce code duplication...
There was a problem hiding this comment.
Agree, but Window() is doing something else as well and it's get bloated. I'll add a Close() function and move out the logic there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After cleaning a list, there is no need to show the list anymore. That's
why we call
Window()to invoke the close function. Remove allWindow()calls and make Clean() more useful to avoid adding the secondline. There is no single
Clean()call independently, so it makes senseto change the meaning