Set up routes so that we can easily add an agency view #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more explicit propTypes to <NibrsContainer /> so that it is obvious what the parent is passing down.
The only remaining thing in the data util was a mapping of crime types. I moved that to the offenses util and removed data.js. Added propType declarations since I was in the file.
jeremiak
changed the title
src/components/Explorer.js
Outdated
| const { crime } = params | ||
| let { place, placeType } = params | ||
|
|
||
| if (!params.place && !params.placeType) { |
There was a problem hiding this comment.
let's pull this out into a function and reuse in componentDidMount too
There was a problem hiding this comment.
i can add within the hour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "breaking" change for end users as URLs have shifted. Instead of a URL like
/explorer/california/violent-crimethe new URL will be/explorer/state/california/violent-crime. This enables us to add other URLs easily, such as/explorer/agency/:ori/:crime.We did a fair bit of refactoring here to try and make the
<Explorer />component a bit easier to understand, so all munging now happens in the respective container children.Before merging:
Should close #693