Use estimated data for trend charts

[jeremiak]

Uses the /estimates endpoint instead of /counts so that the data displayed includes FBI estimates.

Based on #703, which should be merged first.

[jeremiak]

@brendansudol This has been rebased and should be ready for review

[brendansudol]

why did u replace the getPlaceInfo method in componentDidMount and render? i think that helps consolidate this place assignment logic

[jeremiak]

Oops, I think that just got removed when I was fixing rebase conflicts. I'll look for it and take a second look

[brendansudol]

would use ternary here to save a few lines:

const endpoint = (place === nationalKey)
  ? `${API}/estimates/national`
  : `${API}/estimates/states/${lookupUsa(place).toUpperCase()}`

[brendansudol]

i wonder if this function should be in '../util/summary' too and consolidated within the mungeSummaryData call to avoid multiples passes through the data

[brendansudol]

i think this could do the trick:

const mungeSummaryData = (crime, summaries, place, since, until) => {
  if (!summaries || !summaries[place]) return false

  const keys = Object.keys(summaries)
  return summaries[place]
    .filter(d => d.year >= since && d.year <= until)
    .map(year => {
      const data = { date: year.year }
      keys.forEach(key => {
        const source = key !== place
          ? summaries[key].find(d => d.year === data.date)
          : year
        data[key] = {
          pop: source.population,
          count: source[crime],
          rate: source[crime] / source.population * 100000,
        }
      })
      return data
    })
}

note the filter call before the map (and new since and until params)

[brendansudol]

looks good, can review once more and then merge when final tweaks are in

[jeremiak]

Shoot, didn't mean to merge master in. I've got to get better at the fix merge conflicts inside of github.com workflow, but in any case your feedback was received and implemented @brendansudol

[brendansudol]

looks good!