Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm charts for feast jobservice #1081

Merged
merged 7 commits into from
Oct 23, 2020
Merged

Add helm charts for feast jobservice #1081

merged 7 commits into from
Oct 23, 2020

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Oct 21, 2020

What this PR does / why we need it: This PR adds Helm Chart for Feast Job Service. Tested locally on minikube.

Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
@tsotnet
Copy link
Collaborator Author

tsotnet commented Oct 21, 2020

@oavdeev thanks for the comments, I realized most of the clean up stuff and was cleaning up the diff. Didn't find an equivalent functionality of Phabricator's "Plan Changes" to not notify reviewers... Let me know if there's anything else left!

Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
{{- toYaml . | nindent 8 }}
{{- end }}

{{- if .Values.gcpServiceAccount.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hardcode the GCP specific fields here still? I think we want to move away from this (if we support AWS)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woop we should probably handle that in another PR to get this one unblocked.

  • All services (core, serving, jupyter) have the gcp-specific fields, so we need to figure out the overall solution here, not just for job service
  • Looks like for AWS @oavdeev wrote the terraform script that uses envOverrides to override some environment variables, and he won't need to hardcode any AWS-specific stuff. However, this approach can't be used readily, since we don't have terraform for GCP deployment & some of these gcp fields are used outside env variables right now. Therefore I don't have a clear alternative to move these variables to.
  • It won't affect AWS deployment in the short term, so we can temporarily leave it here

Let me know what you think!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, lets go ahead with cleaning this up in another PR.

Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oavdeev, tsotnet
To complete the pull request process, please assign pyalex
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Oct 23, 2020

/retest

Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
@tsotnet
Copy link
Collaborator Author

tsotnet commented Oct 23, 2020

/retest

1 similar comment
@woop
Copy link
Member

woop commented Oct 23, 2020

/retest

@woop woop added the kind/feature New feature or request label Oct 23, 2020
@woop woop merged commit 3261cd0 into master Oct 23, 2020
@woop woop deleted the job-service-helm branch May 12, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants