-
Notifications
You must be signed in to change notification settings - Fork 99
Typescript refactoring, seperate services, custom methods and vitepress docs #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- complete typing - update dependencies - semistandard -> eslint-typescript - start converting tests to typescript - ref #144
- identityChange had no 'field' property - tests fixes
- add passwordField to options - propper typing
- call seperate services from main service
- destructure create-data for better IDE support - move AuthenticationManagementService to seperate file
- completely move `passwordField` to options
- Base class with publish-prevention - `useSeparateServicePaths` option - use internal service.options instead of create({ action: 'options' }) - add tests for publish - add tests for `useSeparateServicePaths` - more typings
- export defaultOptions -> addVerification - path - rearrange useSeparateServices
- divide Service & configure functions - ensure options per Service - types: better types - chore: update dependencies - tests: add tests for separate services - tests: increase about-time to 600
- better typing (abstract _create with type) - sort actions alphabetically
- overview page - started services page
move typescript refactor to repo branch
- refactor: add import type where necessary - refactor: add newlines for function params - refactor: destructure imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested preventChanges fix from 0b66fb8 and that works
- rename user1, user2, user3 to declarative names - use $limit: 2 everywhere - use [passwordField] consequently
I tested verifySignupLong functionality and it works as advertised. Will check the other hooks this week. Well done. |
Mongoose Models need |
- feat: add 'passParams' option
tl;dr
Checkout the migration guide: https://feathers-a-m.netlify.app/migration.html
New Features:
action
has a new separate service now:see #159 for the beginning of Discussion. We continue the refactoring here.
Todos:
src
to typescript is pretty much done with typesclient
is backward compatibletest
to typescriptaction
_create
for every service to make it possible to skip hooks as foradapter-commons
service.publish
does not get hit to prevent channel emitapp.use
)New Stuff:
passwordField
for dynamic passwordField. It was a fixed variable before_create
function on all services to bypass hooksaction: 'options'
)app.service('authManagement')._resetPasswordLong(...)
)app.service('authManagement').resetPasswordLong(...)
app.use('auth-management, new AuthenticationManagementService(app, { ... })
instead ofapp.configure(authManagement)
Todo:
IDE-Support:
closes #144, #138