ES2015 module support for rollup/webpack/... #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and simple enough. Did you get a chance to try it out with Rollup? If it can do tree shaking and export UMD builds I'd be curious how much of a size difference there would be compared to the Browserify feathers-client build we are using right now (it's about ~21k right now minified + gzipped so it's not super important). |
|
no, sorry didn't get around to testing anything |
|
Thanks again for the PR @ForsakenHarmony. I'm closing it in favour of #608 though. |
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Updating changelog * fixing the authentication config key that is referenced. Closes #497 * Work with 'authentication' or 'auth' config key * Fix reference to app -> this.app
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Updating changelog * fixing the authentication config key that is referenced. Closes #497 * Work with 'authentication' or 'auth' config key * Fix reference to app -> this.app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read more
I probably should not have done this on github but it's too late now