Refactor config helper to be cleaner #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
loomlike
added
the
safe to test
xiaoyongzhu
reviewed
Jan 26, 2023
xiaoyongzhu
previously approved these changes
Jan 26, 2023
|
Thanks @loomlike! This looks good to me. Can you also add some of the previous deleted comments to the updated code so folks are aware what's going on? |
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
xiaoyongzhu
approved these changes
Jan 27, 2023
jainr
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Ki Min 42475935+loomlike@users.noreply.github.com
Description
Resolves #987
Also please do review
.github/workflows/pull_request_push_test.ymlfile to make sure the changes are valid. I copied the file from #987.How was this PR tested?
Unittest
Does this PR introduce any user-facing changes?