Fix env logging #987
Closed
Fix env logging #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
added
the
safe to test
xiaoyongzhu
requested review from
blrchen,
enya-yx,
hangfei,
jainr,
mufajjul and
windoze
This reverts commit 9c4f3f7.
blrchen
reviewed
Jan 19, 2023
| @@ -65,6 +65,7 @@ | |||
| "py4j<=0.10.9.7", | |||
| "loguru<=0.6.0", | |||
| "pandas", | |||
| "numpy<=1.20.3", # pin numpy due to pyspark's deprecated np.bool access | |||
There was a problem hiding this comment.
Should this one get reverted?
There was a problem hiding this comment.
I think so, but let's see if all the test can pass, then revert this one. Otherwise one of the test might fail
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few environment variable related issues and tests. Specifically this PR removes the
use_env_varsvariable from all places since it probably doesn't make a lot of sense.