-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code format with the right subfolders #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyongzhu
added
the
safe to test
Tag to execute build pipeline for a PR from forked repo
label
Apr 30, 2022
Add a screenshot for the new structure? |
hangfei
reviewed
Apr 30, 2022
Could you provide a screenshot of the new py docs? |
This reverts commit c522450.
Please test notebook as well since this changes a lot of structural stuff. |
hangfei
approved these changes
Jun 7, 2022
blrchen
approved these changes
Jun 7, 2022
Good catch. I've verified this branch with the latest notebook and all those worked. |
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to add the right folder hierarchy for Feathr code (so that it can be better organized).
Other small improvements include:
pydocs in this PR: https://feathr-xiaoyzhu.readthedocs.io/en/latest/index.html
pydocs in main branch: https://feathr.readthedocs.io/
We should also move the
api
folder out from the python client. Waiting for @blrchen and @YihuiGuo to fix those as there seems to be some dependencies. It's described at #287.This should have no end user impact as end users are using this:
from feathr import X
The new file structure is like this: