Fix Python doc links in Docs and add HdfsSink
back
#383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the side effect of #198
HdfsSink
into__all__
section offeathr_project/feathr/__init__.py
docs/dev_guide/update_python_docs.md
Note:
docs/dev_guide/update_python_docs.md
:__all__
section in__init__.py
(see code here). Every components that are included in the__all__
section is exposed to end users. Others are not exposed in the pydocs.I'm not sure if the
HdfsSink
is not included by design. If it shouldn't expose to users, then the section indocs/concepts/feature-generation.md
should be removed.