Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding better warning message to let user know that config file is missing and they need to set env parameters. #347

Merged
merged 8 commits into from
Jun 13, 2022
Merged

Adding better warning message to let user know that config file is missing and they need to set env parameters. #347

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8a5ce7
Adding EventHub creation to the deployment script
jainr Jun 3, 2022
c1ade5c
Merge branch 'linkedin:main' into main
jainr Jun 3, 2022
8d162f0
Upgrading API versions and fixing the if clause of KV property creati…
jainr Jun 3, 2022
c9bfe05
Merge branch 'main' of github.com:jainr/feathr into main
jainr Jun 3, 2022
1a6161f
Merge branch 'main' of https://github.com/linkedin/feathr into main
jainr Jun 6, 2022
f0f91fa
Merge branch 'main' of https://github.com/linkedin/feathr into rijai/…
jainr Jun 10, 2022
31ef89d
Making the warning message more clear
jainr Jun 10, 2022
848fe0e
Minor edit
jainr Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feathr_project/feathr/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def __init__(self, config_path:str = "./feathr_config.yaml", local_workspace_dir
self.envutils = envutils

if not os.path.exists(config_path):
self.logger.warning('Configuration path does not exist, you need to set the environment variables explicitly. For all the environment variables, please refer to https://github.com/linkedin/feathr/blob/main/feathr_project/feathrcli/data/feathr_user_workspace/feathr_config.yaml')
self.logger.warning('No Configuration file exist at the user provided config_path or the default config_path (./feathr_config.yaml), you need to set the environment variables explicitly. For all the environment variables that you need to set, please refer to https://github.com/linkedin/feathr/blob/main/feathr_project/feathrcli/data/feathr_user_workspace/feathr_config.yaml')

# Load all configs from yaml at initialization
# DO NOT load any configs from yaml during runtime.
Expand Down