Skip to content

Conversation

@paulirwin
Copy link
Member

Fixes #41

Note that this does not provide any security guarantees, as the keypair is included in the repo on purpose. This is solely for legacy .NET Framework compatibility for use cases that require it.

Our intention is to drop this in a future version when .NET Framework support is too difficult to maintain.

@paulirwin paulirwin requested a review from Copilot October 22, 2025 15:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables strong-name signing of assemblies to support legacy .NET Framework compatibility. The keypair is intentionally included in the repository without security guarantees, with plans to remove this feature when .NET Framework support becomes too burdensome to maintain.

Key changes:

  • Added strong-name signing configuration via Directory.Build.props files
  • Updated InternalsVisibleTo attribute to include the public key for the signed test assembly
  • Corrected project structure by moving benchmark project path references

Reviewed Changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Directory.Build.props Root configuration file enabling assembly signing for all projects
src/Directory.Build.props Imports parent signing configuration for source projects
test/Directory.Build.props Imports parent signing configuration for test projects
src/F23.StringSimilarity/Properties/AssemblyInfo.cs Updated InternalsVisibleTo with public key for signed test assembly
test/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj Fixed project reference path to correct location
F23.StringSimilarity.sln Corrected benchmark project path in solution file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@paulirwin paulirwin merged commit 0c4f2f6 into main Oct 22, 2025
3 checks passed
@paulirwin paulirwin deleted the issue/41 branch October 22, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Strong-Named Assemblies

2 participants