-
Notifications
You must be signed in to change notification settings - Fork 72
Strongly-name assemblies for legacy compatibility, #41 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables strong-name signing of assemblies to support legacy .NET Framework compatibility. The keypair is intentionally included in the repository without security guarantees, with plans to remove this feature when .NET Framework support becomes too burdensome to maintain.
Key changes:
- Added strong-name signing configuration via
Directory.Build.propsfiles - Updated
InternalsVisibleToattribute to include the public key for the signed test assembly - Corrected project structure by moving benchmark project path references
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Root configuration file enabling assembly signing for all projects |
| src/Directory.Build.props | Imports parent signing configuration for source projects |
| test/Directory.Build.props | Imports parent signing configuration for test projects |
| src/F23.StringSimilarity/Properties/AssemblyInfo.cs | Updated InternalsVisibleTo with public key for signed test assembly |
| test/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj | Fixed project reference path to correct location |
| F23.StringSimilarity.sln | Corrected benchmark project path in solution file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #41
Note that this does not provide any security guarantees, as the keypair is included in the repo on purpose. This is solely for legacy .NET Framework compatibility for use cases that require it.
Our intention is to drop this in a future version when .NET Framework support is too difficult to maintain.