Skip to content

Strongly-name assemblies for legacy compatibility, #41 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirwin merged 13 commits into from
Oct 22, 2025
Merged

Strongly-name assemblies for legacy compatibility, #41 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
67d8324
Generate strong-name keypair
paulirwin Oct 22, 2025
132d2cd
Sign assembly; move benchmarks to test folder
paulirwin Oct 22, 2025
ea97237
Run tests on all platforms; remove .NET 6 setup
paulirwin Oct 22, 2025
c9d740e
Run tests on net9 and net10 too
paulirwin Oct 22, 2025
3b5c693
Use setup-dotnet@v5
paulirwin Oct 22, 2025
c5414f2
Upgrade System.Memory
paulirwin Oct 22, 2025
c1450c6
Install .NET 10 on CodeQL
paulirwin Oct 22, 2025
b0c3253
Upgrade NuGet packages to address vulnerabilities
paulirwin Oct 22, 2025
7f8e1e3
Disable CodeQL autobuild until it supports .NET 10
paulirwin Oct 22, 2025
6d0bff8
Upgrade deprecated codeql tasks
paulirwin Oct 22, 2025
35a596e
Upgrade deprecated codeql tasks
paulirwin Oct 22, 2025
67af372
Attempt using autobuild v3
paulirwin Oct 22, 2025
e824ab9
Remove CodeQL workflow until they get it working on .NET 10
paulirwin Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 0 additions & 70 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop

This file was deleted.

18 changes: 10 additions & 8 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,21 @@ on:

jobs:
build:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]

runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v2
- name: Setup .NET 6
uses: actions/setup-dotnet@v1
- name: Setup .NET SDKs
uses: actions/setup-dotnet@v5
with:
dotnet-version: 6.0.x
- name: Setup .NET 8
uses: actions/setup-dotnet@v1
with:
dotnet-version: 8.0.x
dotnet-version: |
10.0.x
9.0.x
8.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
6 changes: 6 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup Label="Assembly signing">
<AssemblyOriginatorKeyFile>$(SolutionDir)StringSimilarity.NET.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion F23.StringSimilarity.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "F23.StringSimilarity", "src
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "F23.StringSimilarity.Tests", "test\F23.StringSimilarity.Tests\F23.StringSimilarity.Tests.csproj", "{68F339E6-278F-4B04-A6ED-422AAD30591F}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "F23.StringSimilarity.Benchmarks", "F23.StringSimilarity.Benchmarks\F23.StringSimilarity.Benchmarks.csproj", "{3A9605B1-820C-43C2-8F9B-72BCA5F5543B}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "F23.StringSimilarity.Benchmarks", "test\F23.StringSimilarity.Benchmarks\F23.StringSimilarity.Benchmarks.csproj", "{3A9605B1-820C-43C2-8F9B-72BCA5F5543B}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Binary file added StringSimilarity.NET.snk
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<Project>
<!-- include parent folder props -->
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
</Project>
4 changes: 2 additions & 2 deletions src/F23.StringSimilarity/F23.StringSimilarity.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
<PackageReference Include="System.Memory" Version="4.5.4" />
<PackageReference Include="System.Memory" Version="4.6.3" />
</ItemGroup>
<ItemGroup>
<None Include="logo.png" Pack="true" PackagePath="\" />
</ItemGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<DocumentationFile>bin\Release\netstandard2.0\F23.StringSimilarity.xml</DocumentationFile>
</PropertyGroup>
</Project>
</Project>
2 changes: 1 addition & 1 deletion src/F23.StringSimilarity/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("F23.StringSimilarity.Tests")]
[assembly: InternalsVisibleTo("F23.StringSimilarity.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100b9a3cf7cbdb26a91b8a50d70ec052fe9f1edd3d1989e1079d0b0c1930e2030273a82629e18c7f2932a1e7957d48ec36b2703cda7bab46f3a0684cc86637e02dac24c857a43ef9a63a6459b147d11ec43b75b181de0aa326931ae13ba31c06977b309424c730d895144feab54da5ad84a604f90b2d672406177782027c8413caa")]
4 changes: 4 additions & 0 deletions test/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<Project>
<!-- include parent folder props -->
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
</Project>
0 ...StringSimilarity.Benchmarks/Benchmarks.cs → ...StringSimilarity.Benchmarks/Benchmarks.cs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ks/F23.StringSimilarity.Benchmarks.csproj → ...ks/F23.StringSimilarity.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\src\F23.StringSimilarity\F23.StringSimilarity.csproj" />
<ProjectReference Include="..\..\src\F23.StringSimilarity\F23.StringSimilarity.csproj" />
</ItemGroup>

</Project>
0 F23.StringSimilarity.Benchmarks/Program.cs → ...23.StringSimilarity.Benchmarks/Program.cs
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions test/F23.StringSimilarity.Tests/F23.StringSimilarity.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOsPlatform('Windows'))">$(TargetFrameworks);net481</TargetFrameworks>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
Expand All @@ -18,9 +18,9 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down