Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sharing fedoralovespython on social media #31

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nmilosev
Copy link
Member

@nmilosev nmilosev commented Feb 22, 2017

Enable pretty Twitter and FB formatting.

Add new image for sharing (fedoralovespython-share.jpg)

  • only JPEG images are allowed

Add metadata for FB and twitter

Facebook validator shows some warnings which can be ignored:

Related issue: #25

@nmilosev
Copy link
Member Author

TODO: check the description please

@nmilosev
Copy link
Member Author

Twitter:

screenshot from 2017-02-22 16-43-08

Facebook:

screenshot from 2017-02-22 16-44-04

Ignore the IP address, that was my testing DO droplet.

Enable pretty Twitter and FB formatting.

Add new image for sharing (fedoralovespython-share.jpg)

only JPEG images are allowed
Add metadata for FB and twitter

validated with https://cards-dev.twitter.com/validator (Twitter) and
https://developers.facebook.com/tools/debug/og/object/
Facebook validator shows some warnings which can be ignored:

http://stackoverflow.com/questions/16475336/open-graph-twitter-cards-html5-incompatible

Related issue: fedora-python#25
@hroncok
Copy link
Member

hroncok commented Feb 22, 2017

I'd suggest smaller margin in the image. Like this (don't use this one, it's not cropped with any precision).

flp

@nmilosev
Copy link
Member Author

I'd suggest smaller margin in the image. Like this (don't use this one, it's not cropped with any precision).

Done.

Twitter screenshot:

screenshot from 2017-02-22 17-00-42

Facebook still has old one cached, will update asap. Can squash into one commit.

@hroncok
Copy link
Member

hroncok commented Feb 22, 2017

Could you plese do a deploy as described in https://github.com/fedora-python/fedoralovespython.org#hacking ?

If there is anything unclear about it, ask and I'll update the instructions.

<!-- For Facebook and Twitter: -->
<meta property="og:type" content="article">
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org">
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the probably - let us brag a little.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/-/–/ here as well

@@ -4,6 +4,16 @@
<link href="{{ url_for('static', filename='style.css') }}" rel="stylesheet">
<link href="{{ url_for('static', filename='favicon.ico') }}" rel="shortcut icon" type="image/x-icon">
<link href='https://fonts.googleapis.com/css?family=Open+Sans:400,400italic,600,600italic&amp;subset=latin' rel='stylesheet' type='text/css'>
<!-- For Facebook and Twitter: -->
<meta property="og:type" content="article">
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/-/–/

<meta property="og:type" content="article">
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org">
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!">
<meta property="og:url" content="https://fedoralovespython.org/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the pages's url? There's also /__future__/

<meta property="og:type" content="article">
<meta property="og:title" content="Fedora Loves Python – fedoralovespython.org">
<meta property="og:description" content="Fedora’s relationship with Python is very close, making it the best platform for developing with Python - learn why!">
<meta property="og:url" content="https://fedoralovespython.org/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shall be with __future__ on the __future__ page

@hroncok
Copy link
Member

hroncok commented Jun 5, 2017

@nmilosev what's the status?

@nmilosev
Copy link
Member Author

nmilosev commented Jun 5, 2017

I completely forgot about this. :(

I think it's pretty complete, just needs a final check from you. That is of course if the API hasn't changed. :D

We lost a lost of time trying to setup my GH pages last time, so maybe it's better if you can finish this one off. As far as I can remember the only thing needed doing is changing the hardcoded link in the template.

If you need help, please let me know. :)

@hroncok hroncok marked this pull request as draft May 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants