Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Sharing fedoralovespython on social media #31

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[WIP] Sharing fedoralovespython on social media #31

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e64a2f
Sharing fedoralovespython on social media
nmilosev Feb 22, 2017
7611cef
New image for fedoralovespython sharing
nmilosev Feb 22, 2017
a85e5b7
Small modifications to the title and desc.
nmilosev Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added static/img/fedoralovespython-share.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
<link href="{{ url_for('static', filename='style.css') }}" rel="stylesheet">
<link href="{{ url_for('static', filename='favicon.ico') }}" rel="shortcut icon" type="image/x-icon">
<link href='https://fonts.googleapis.com/css?family=Open+Sans:400,400italic,600,600italic&amp;subset=latin' rel='stylesheet' type='text/css'>
<!-- For Facebook and Twitter: -->
<meta property="og:type" content="article">
<meta property="og:title" content="Fedora Loves Python - fedoralovespython.org">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/-/–/

<meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the probably - let us brag a little.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/-/–/ here as well

<meta property="og:url" content="https://fedoralovespython.org/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the pages's url? There's also /__future__/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shall be with __future__ on the __future__ page

<meta property="og:image" content="{{ url_for('static', filename='img/fedoralovespython-share.jpg', _external=True) }}">
<!-- Additionaly, for Twitter: -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:site" content="@fedora">
<meta property="twitter:creator" content="@fedora" />
</head>
<body>
<header>
Expand Down