Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose functions to get GPS latitude, longitude and altitude separately #43

Closed
wants to merge 3 commits into from

Conversation

jonas-hagen
Copy link

Suggestion: A possible (partial?) solution to #42.

The gexiv2 functions to access GPS latitude, longitude and altitude are exposed. The already present function get_gps_info() returns None if the altitude is not set. These newly exposed functions allow access to latitude and longitude in this (quite common) case.

@felixc
Copy link
Owner

felixc commented Jul 18, 2021

Hey!

Thanks for the PR — I especially appreciate that you added example code for it :)

Like I mentioned in #42, I'm not sure I'm understanding the root cause correctly, so let's discuss there before merging this — but it certainly looks good to me and I'm in favour of landing it.

Could you please also add yourself to the CONTRIBUTORS.md file?

@jonas-hagen
Copy link
Author

Thanks for your comments! I will then update the PR.

@felixc
Copy link
Owner

felixc commented Jan 30, 2023

Thanks for presenting the two options. I've gone with the other alternative (though with a variant implementation), so I think we can close this now. #69 landed instead. Please comment on #42 if you think we should reconsider this approach instead!

@felixc felixc closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants