Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make altitude optional in GPS info #44

Closed
wants to merge 3 commits into from

Conversation

jonas-hagen
Copy link

This implies: For setting GPS info, the three components need to be supplied explicitly and separate.
This is not ideal because of the asymmetry in get / set GPS info. Since gexiv2 does not export a method to set the coordinates separately, this is the best option if altitude shall be optional in GPS Info.

See discussion in #42 (alternative solution in #43 ).

This implies: For setting GPS info, the three components need to be supplied
explicitly and separate.
This is not ideal because of the asymmetry in get / set GPS info. Since gexiv2
does not export a method to set the coordinates separately, this is the best
option for now.
@felixc
Copy link
Owner

felixc commented Jan 30, 2023

Thank you for taking the time to put together this option for fixing the bug. I've merged #69 which takes a similar approach, so I think this is now redundant. However if you feel this version has a better API or anything like that, please feel free to discuss on #42 and we can figure it out!

@felixc felixc closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants