This repository has been archived by the owner on Apr 30, 2018. It is now read-only.
fix: can't redefine process.env when node<4 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
force-pushed
the
fix-restore-process-env
branch
from
9a952de
to
4765c22
Compare
popomore
changed the title
popomore
changed the title
| cache.set(obj, flag); | ||
| } | ||
| flag.add(key); | ||
|
|
||
| // Can't not delete the property of process.env before node@4 | ||
| if (obj === process.env) { | ||
| obj[key] = method; |
There was a problem hiding this comment.
missed this condition
|
Sweet |
|
0.5.1 |
fent
added a commit
that referenced
this pull request
Jan 13, 2018
fix: can't redefine process.env when node<4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node#2999