v8: let Object.defineProperty work with process.env #2999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For posterity, that CL landed in v8/v8@fa3e6c0 and doesn't touch src/runtime/runtime-object.cc. I'm a bit hesitant to land this PR. The changes to runtime-object.cc don't look obviously correct to me. /cc @nodejs/build - can we have an option to run the V8 test suite on the CI as well? |
ChALkeR
added
v8 engine
|
Is this related to #3375? cc @trevnorris? |
|
@Fishrock123 Don't believe so. |
|
The question is: will there be another 3.3.x release? |
|
Last 3.x release scheduled @ #3465, if someone really wants this in then you'll have to work hard at it. If @bnoordhuis is not happy with the look of it then I'd not be hopeful. /cc @nodejs/v8 - anyone brave enough to sign off on this? |
Closed
|
There will be no new 3.x releases, per #3465 (comment). |
popomore
added a commit
to fent/node-muk
that referenced
this pull request
Jun 12, 2016
popomore
added a commit
to fent/node-muk
that referenced
this pull request
Jun 12, 2016
fent
pushed a commit
to fent/node-muk
that referenced
this pull request
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2998.
This is only a back port to v3.x since the bug will not emerge in v4.x. It turned out that the v8 team encountered a similar bug regarding
window.localStoragein Chrome and landed a patch in Jun which is consequently applied into Node 4.x.https://codereview.chromium.org/1180073002
However the patch is too big to back port to v3.x. I made a minimal version and therefore come this PR.