Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transform containers/settings from js to tsx #384

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

cino
Copy link
Contributor

@cino cino commented Jun 27, 2022

Description of Change

  • Converted the files in .src/containers/layout and .src/containers/settings from js to tsx

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally - assume its working.

Copy link
Member

@SpecialAro SpecialAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, haven't tested locally

@SpecialAro
Copy link
Member

Tested locally now, seems ok. Merging...

Thank you @cino !

@SpecialAro SpecialAro force-pushed the typescript-containers-settings branch from a656197 to d93692f Compare June 27, 2022 16:21
@SpecialAro SpecialAro merged commit 0bf1368 into ferdium:develop Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants