Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to typescript #42

Open
vraravam opened this issue Apr 25, 2022 · 7 comments
Open

Convert to typescript #42

vraravam opened this issue Apr 25, 2022 · 7 comments

Comments

@vraravam
Copy link
Contributor

Your issue

The conversion to typescript was started by @mcmxcdev and myself back in the ferdi days. That effort was done piece-meal in small chunks, but has since come to a state where some portion of the codebase is in ts while other portions are in js. Need to restart that conversion

@SlanDF
Copy link
Contributor

SlanDF commented Jul 13, 2022

@SpecialAro is this issue ticket still relevant?

@SpecialAro
Copy link
Member

@SpecialAro is this issue ticket still relevant?

Yes. It's sill an ongoing task.

@cino
Copy link
Contributor

cino commented Jul 13, 2022

@SlanDF
image

Highly relevant as you can see :)

@balajiv113
Copy link
Contributor

I am looking to contribute towards this, is there any priority on which needs to be done first ??

@cino
Copy link
Contributor

cino commented Oct 22, 2022

@balajiv113 There isn't really any priority on it, I'd suggest anything can be converted, I would just ignore the API folder as there is another pull request open with a major upgrade of the whole API which will be ported/integrated here.

@ghost
Copy link

ghost commented Nov 24, 2022

Hi Team,
FYI - After the commit #797 merge, we shall reached a stage where all Ferdium app files ( excluding internal-server files) are converted to TS

Regarding internal-server approx. ~38 files (8.9% approx.) are in js form
which shall be removed after implementation of V2 TS ferdium-server - plan is to use same ferdium server(configured for single tenant) here as submodule in ferdium app.

PFB - TS conversion progress.

image

@ghost
Copy link

ghost commented Nov 24, 2022

FYI - I shall further involve in cleanup activities that are spilled over in transformation

Queue:

  • need to update eslint settings w.r.t typescript update and try to remove other quality check tools like prettier or common lint or editor config (After discussion and validation with team)
  • refactor all ui components.
  • pass readOnly to the display strings as Input (to avoid user from seeing cursor)
  • remove all ()=>{} to noop (import from lodash) for cleaner
  • check/ correct typing, style of code and refactor if needed
  • Remove all any (return type)
  • try to implement private variable if needed
  • Handle import cycles
  • Clear all tech dept occured in this TS transformation (address TODO)

Thanks for support folks :)

@ghost ghost moved this from New to Todo in Ferdium Nov 24, 2022
@ghost ghost moved this from Todo to In Progress in Ferdium Nov 24, 2022
ghost pushed a commit to MuhamedSalihSeyedIbrahim/ferdium-app that referenced this issue Nov 30, 2022
ghost pushed a commit to MuhamedSalihSeyedIbrahim/ferdium-app that referenced this issue Nov 30, 2022
ghost pushed a commit to MuhamedSalihSeyedIbrahim/ferdium-app that referenced this issue Nov 30, 2022
@ghost ghost mentioned this issue Nov 30, 2022
7 tasks
ghost pushed a commit to MuhamedSalihSeyedIbrahim/ferdium-app that referenced this issue Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

5 participants