Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn error boundary into typescript #387

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

cino
Copy link
Contributor

@cino cino commented Jun 27, 2022

Description of Change

  • Turned the ./src/components/util/ErrorBoundary into typescript
  • Also renamed an import/function call from injectSheet to withStyles to be in line with documentation of the corresponding library and planning to do that throughout the project.

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally, assume its working.

@vraravam vraravam merged commit 8715d48 into ferdium:develop Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants