Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform welcome component tree to TS #715

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Transform welcome component tree to TS #715

merged 2 commits into from
Oct 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2022

Pre-flight Checklist

Description of Change

  • chore: apply read only prop in input component
  • chore: transform welcome component tree to TS

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

@ghost ghost marked this pull request as ready for review October 27, 2022 20:54
@ghost ghost self-requested a review as a code owner October 27, 2022 20:54
vraravam
vraravam approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test locally due to npm/pnpm issues. Code looks good to merge.

@vraravam vraravam assigned ghost Oct 28, 2022
@vraravam vraravam merged commit d955733 into ferdium:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest tech debt 💲
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vraravam