Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slack recipe, Input & Toggle issue due to typescript conversion #746

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2022

Pre-flight Checklist

Description of Change

  • fix: slack issue caused by input TS conversion
  • fix: button event handler type
  • fix: inconsistent file import path w.r.t toggle
  • refactor: remove toggle component's duplicate
  • refactor: TrayIcon class property TrayIcon rename to tray

Motivation and Context

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

@ghost ghost self-requested a review as a code owner November 8, 2022 02:34
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these work with the PR branch!

  • editing of an existing workspace, creating a new workspace, adding/removing services from workspaces
  • adding slack afresh, editing slack, removing slack
  • editing pre-existing gmail

@vraravam
Copy link
Contributor

vraravam commented Nov 8, 2022

If anyone merges this PR, please DO NOT squash, instead - please rebase the 2 commits so that they can be tracked separately in the future. Thanks!

@vraravam vraravam assigned ghost Nov 8, 2022
@vraravam vraravam changed the title Fix slack recipe, Input & Toggle issue due to TS conversion & refactor Fix slack recipe, Input & Toggle issue due to typescript conversion Nov 8, 2022
@SpecialAro
Copy link
Member

Just tested on Windows 11 and it is working properly now. Thank you!

image

@vraravam vraravam merged commit 570d26b into ferdium:develop Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants