Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound HTTP #965

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Outbound HTTP #965

merged 1 commit into from
Oct 29, 2023

Conversation

itowlson
Copy link
Contributor

@itowlson itowlson commented Oct 26, 2023

There is probably more to do on this but it's not fully working right now... grin I understand Python and JS are not changing on day one, and will likely get support via componentise-blah tools rather than the current plugins; I am not 100% sure about Go but guess it is staying the same for now...?

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date` are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
  • Has passed bart check

✅ content/spin/v2/http-outbound.md
✅ content/spin/v2/rust-components.md

  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)

Screenshot 2023-10-30 at 07 19 22

  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors

Screenshot 2023-10-30 at 07 13 12

  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@lann
Copy link
Contributor

lann commented Oct 27, 2023

I'm proposing a simplification of this interface: fermyon/spin#1977

Feel free to veto it into >2.0.0, though note that the code here would still work either way so it could just be a post-release docs update.

@itowlson itowlson requested a review from tpmccallum October 29, 2023 18:09
Copy link
Contributor

@tpmccallum tpmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itowlson itowlson merged commit f10e5bb into fermyon:main Oct 29, 2023
3 checks passed
@itowlson
Copy link
Contributor Author

We will need to revisit this as final changes stabilise in Spin main, but merging for now after discussion with @tpmccallum so that we minimise the number of merge conflicts in waiting long-running PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants