rust: Add some convenience methods/impls to http types #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
force-pushed
the
enhance-http-types
branch
from
94d95a7 to
c8e0961
Compare
radu-matei
approved these changes
Oct 27, 2023
lann
force-pushed
the
enhance-http-types
branch
from
c8e0961 to
70f50c9
Compare
And update rust outbound http examples to use "simple" types.
- Add `Request::{get,post}` associated functions which cover the most
common request types.
- `impl TryIntoOutgoingRequest for RequestBuilder` to skip a boilerplate
`.build()`
- Add `Response::into_builder` to ease returning an updated response.
- `impl Debug for Response` to fix examples
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
enhance-http-types
branch
from
70f50c9 to
3821266
Compare
rylev
reviewed
Oct 31, 2023
| @@ -528,6 +530,16 @@ impl TryIntoOutgoingRequest for Request { | |||
| } | |||
| } | |||
|
|
|||
| impl TryIntoOutgoingRequest for RequestBuilder { | |||
There was a problem hiding this comment.
We should probably do the same for IntoResponse for ResponseBuilder.
rylev
reviewed
Oct 31, 2023
| f.debug_struct("Response") | ||
| .field("status", &self.status) | ||
| .field("headers", &self.headers) | ||
| .field("body.len()", &self.body.len()) |
There was a problem hiding this comment.
I wonder if this would be more useful:
.field("body.", String::from_utf8_lossy(&self.body[..self.body.len().min(50)]))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This whole PR is summed up by this
http-rust-outbound-httpexample diff.Draft until #1975 merges.
And update rust outbound http examples to use "simple" types.
Request::{get,post}associated functions which cover the most common request types.impl TryIntoOutgoingRequest for RequestBuilderto skip a boilerplate.build()Response::into_builderto ease returning an updated response.impl Debug for Responseto fix examples