Fix URL output

[kj187]

No description provided.

[fernando-mc]

Thanks for the PR @kj187.

I'll look at this a bit in detail after work but I think AWS has two different URLs that the files will show up at. Did I mess mine up completely? Or is it possible both your version and my version are correct?

If we can, I'd say we just output both formats of the URL.

[fernando-mc]

@kj187 This is what I was referencing - http://docs.aws.amazon.com/AmazonS3/latest/dev/WebsiteEndpoints.html

The two general forms of an Amazon S3 website endpoint are as follows:
bucket-name.s3-website-region.amazonaws.com
bucket-name.s3-website.region.amazonaws.com

It also looks like there is some variation in the erndpoints depending on region?
http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_website_region_endpoints

I might have to take a closer look at all this to see which of these work and don't and which we should be outputting.

[amsross]

What about the format http://${bucket-name}.s3-website-us-east-1.amazonaws.com/?

Although https://s3.amazonaws.com/${bucket-name} is both valid and HTTPS, using that to view a static site with relative URLs is not possible.

It is possible that all three types should be returned?

[fernando-mc]

@amsross I think that's a valid point. I honestly haven't had time to look at all the valid URLs that can be made by AWS when deploying a static site on top of the ones that you might use to reference files directly in S3.

Here's a sample app I've deployed with this if you want to test how you can access the site:
http://node-serverless-text-message-app.s3-website-us-east-1.amazonaws.com

I could access the index page with the bucket/key. But I think this isn't technically the static site URL. It's the S3 URL to get the file. http://s3.amazonaws.com/node-serverless-text-message-app/index.

If anyone wants to speed up the PR for any changes here then I think we might want to know:

1. What the "official" AWS static site endpoint 'formula' for creating the static site URLs is
2. If anyone cares about this outputting the non-official urls you could access the site by.

After reviewing all this I'm inclined to say we stay pretty succinct here and just output the official one.

[fernando-mc]

Closing this in favor of #13