Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly display s3 url based on documentation #2

Closed
wants to merge 2 commits into from
Closed

Correctly display s3 url based on documentation #2

wants to merge 2 commits into from

Conversation

amsross
Copy link

@amsross amsross commented Nov 23, 2017

  • Correctly display s3 url based on the formats laid out for specific regions in the documentation.
  • Add a log the subdomained version of the url

These changes were made according to the documentation on these pages:

Julian Kleinhans and others added 2 commits October 13, 2017 17:14
Also log the subdomained version of the url
@amsross
Copy link
Author

amsross commented Nov 23, 2017

Sorry, I meant to open this against https://github.com/fernando-mc/serverless-finch regarding fernando-mc#6

@amsross amsross closed this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant