Upgrade wrtc to latest release and drop its detection as unnecessary #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-mullen
approved these changes
Apr 13, 2018
|
Restarted the tests after merging the airtap update and now the sauce labs tests are skipped because credentials are missing on PRs. :) |
|
|
FredZeng
pushed a commit
to FredZeng/simple-peer
that referenced
this pull request
Oct 14, 2023
Upgrade wrtc to latest release and drop its detection as unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_isWrtcwas needed becauseonnegotiationneededwasn't implemented in wrtc.Now with wrtc 0.1.0
onnegotiationneededis supported andonnegotiationneededis not longer used after #250 was merged. So there is no reason to keep_isWrtc.Also wrtc starts following semver, hence
^0.1.0.