Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrtc to the latest version 🚀 #267

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 30, 2018

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 0.1.0 of wrtc was just published.

Dependency wrtc
Current Version 0.0.67
Type devDependency

The version 0.1.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of wrtc.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v0.1.0

This project will begin to follow SemVer in preparation for a 1.0.0 release.

New Features

Besides updating to WebRTC M60 (using mayeut/libwebrtc), this release adds a number of features that bring node-webrtc closer to standards-compliance. We still have a ways to go, but we're now testing against w3c/web-platform-tests.

RTCConfiguration

RTCPeerConnection's constructor now accepts the following standard properties:

  • bundlePolicy
  • iceCandidatePoolSize
  • iceServers (no support for OAuth yet)
  • iceTransportPolicy
  • rtcpMuxPolicy

RTCConfiguration also accepts a non-standard property, portRange. This property constrains the port range used by the RTCPeerConnection's ICE transports. For example,

const { RTCPeerConnection } = require('wrtc');

const pc = new RTCPeerConnection({
portRange: {
min: 10000, // defaults to 0
max: 20000 // defaults to 65535
}
});

RTCPeerConnection

RTCPeerConnection now supports two new methods:

  • getConfiguration
  • setConfiguration

RTCPeerConnection now supports the following properties:

  • canTrickleIceCandidates (always returns null for now)
  • connectionState (derived from iceConnectionState)
  • currentLocalDescription
  • currentRemoteDescription
  • pendingLocalDescription
  • pendingRemoteDescription

RTCPeerConnection now supports the following events:

  • "connectionstatechange"
  • "negotiationneeded"

RTCOfferOptions and RTCAnswerOptions

RTCPeerConnection's createOffer method now accepts RTCOfferOptions, and RTCPeerConnection's createAnswer method now accepts RTCAnswerOptions. RTCOfferOptions supports

  • iceRestart
  • offerToReceiveAudio
  • offerToReceiveVideo

Both RTCOfferOptions and RTCAnswerOptions support voiceActivityDetection.

RTCDataChannelInit

RTCPeerConnection's createDataChannel method now accepts

  • id
  • maxPacketLifeTime
  • maxRetransmits
  • negotiated
  • ordered
  • protocol

RTCDataChannel

RTCDataChannel supports the following properties:

  • id
  • maxRetransmits
  • ordered
  • priority (always returns "high")
  • protocol

RTCDataChannel's send method now supports sending Blobs provided by jsdom; however, there is no support for receiving Blobs.

Top-level Exports

Added top-level exports for

  • RTCDataChannel
  • RTCDataChannelEvent
  • RTCPeerConnectionIceEvent

Bug Fixes

  • Fixed a failed assertion when closing RTCPeerConnection's or RTCDataChannel's event loop (#376).
  • Moved AudioDeviceModule construction to the worker thread. This fixes a thread checker assertion raised by debug builds of libwebrtc.
  • Copy StatsReports on the signaling thread. This fixes a thread checker assertion raised by debug builds of libwebrtc.

Breaking Changes

  • Dropped support for "moz"- and "webkit"-prefixed WebRTC APIs in lib/browser.js. This means that, when bundling JavaScript that depends on node-webrtc for the browser, the resulting bundle will no longer depend on these APIs (#369).
  • Dropped support for the now non-standard url attribute in RTCIceServer.
  • Dropped support for the RTCIceConnectionStates, RTCIceGatheringStates, and RTCSignalingStates properties on the RTCPeerConnection prototype. These were an implementation detail that some libraries used for detecting node-webrtc.
  • Dropped support for the RTCDataStates and BinaryTypes properties on the RTCDataChannel prototype. This, too, was an implementation detail.
Commits

The new version differs by 72 commits.

  • 1c6493f Update CHANGELOG.md and README.md (#380)
  • 202e919 [publish binary] wrtc@0.1.0
  • 35f5ced Prepare for 0.1.0 (#379)
  • b0cc60c Run make format
  • ced77ae Add support for onnegotiationneeded
  • 68cb07c Address make check feedback
  • 4a6d751 Make progress on RTCDataChannel-send.html
  • 002c50f Pass RTCPeerConnection-setRemoteDescription-pranswer.html
  • 7cb6a89 Pass RTCPeerConnection-setRemoteDescription-answer.html
  • ff57143 Pass RTCPeerConnection-setLocalDescription-answer.html
  • 6d25bb5 Try to fix Windows
  • a27cfdd Pass RTCPeerConnection-setLocalDescription.html
  • 6f789cd Pass promises-call.html
  • 1e361c3 Pass no-media-call.html
  • 3c95725 Pass RTCPeerConnection-ondatachannel.html

There are 72 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@nazar-pc
Copy link
Collaborator

Closing in favor of similar #266

@nazar-pc nazar-pc closed this Mar 30, 2018
@nazar-pc nazar-pc deleted the greenkeeper/wrtc-0.1.0 branch March 30, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant