Increase cert lock time #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kfigiela ! |
bungle
added a commit
to Kong/kong
that referenced
this pull request
Sep 29, 2021
### Summary #### bug fixes - ***:** use a standarlized log interface [0ff01bd](fffonion/lua-resty-acme@0ff01bd) - **autossl:** release update_lock after cert is created to allow multiple type of certs for same domain to be created within short time [e315070](fffonion/lua-resty-acme@e315070) - **autossl:** increase cert lock time ([#47](fffonion/lua-resty-acme#47)) [efb0602](fffonion/lua-resty-acme@efb0602) - **tls-alpn-01:** set version 3 in certificate generated ([#49](fffonion/lua-resty-acme#49)) [887cad8](fffonion/lua-resty-acme@887cad8)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Sep 29, 2021
### Summary #### bug fixes - ***:** use a standarlized log interface [0ff01bd](fffonion/lua-resty-acme@0ff01bd) - **autossl:** release update_lock after cert is created to allow multiple type of certs for same domain to be created within short time [e315070](fffonion/lua-resty-acme@e315070) - **autossl:** increase cert lock time ([#47](fffonion/lua-resty-acme#47)) [efb0602](fffonion/lua-resty-acme@efb0602) - **tls-alpn-01:** set version 3 in certificate generated ([#49](fffonion/lua-resty-acme#49)) [887cad8](fffonion/lua-resty-acme@887cad8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug related when multiple instances of openresty are running (e.g. behind network load balancer). In such case, two instances may start certificate renewal at the same time (close enough). As indicated in #40 (comment)
This PR workarounds the issue by increasing lock TTL.