Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version 3 in certificate generated for tls-alpn-01 challenge #49

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Sep 3, 2021

This PR sets the certificate version as 3 in the tls-alpn-01 challenge

closes #48

@fffonion
Copy link
Owner

fffonion commented Sep 3, 2021

Thanks @nizar-m ! CI is broken but is unrelated, I will fix that later.

@fffonion fffonion merged commit 887cad8 into fffonion:master Sep 3, 2021
@nizar-m nizar-m deleted the tls-alpn-challenge-version branch September 4, 2021 20:46
bungle added a commit to Kong/kong that referenced this pull request Sep 29, 2021
### Summary

#### bug fixes
- ***:** use a standarlized log interface [0ff01bd](fffonion/lua-resty-acme@0ff01bd)
- **autossl:** release update_lock after cert is created to allow multiple type of certs for same domain to be created within short time [e315070](fffonion/lua-resty-acme@e315070)
- **autossl:** increase cert lock time ([#47](fffonion/lua-resty-acme#47)) [efb0602](fffonion/lua-resty-acme@efb0602)
- **tls-alpn-01:** set version 3 in certificate generated ([#49](fffonion/lua-resty-acme#49)) [887cad8](fffonion/lua-resty-acme@887cad8)
bungle added a commit to Kong/kong that referenced this pull request Sep 29, 2021
### Summary

#### bug fixes
- ***:** use a standarlized log interface [0ff01bd](fffonion/lua-resty-acme@0ff01bd)
- **autossl:** release update_lock after cert is created to allow multiple type of certs for same domain to be created within short time [e315070](fffonion/lua-resty-acme@e315070)
- **autossl:** increase cert lock time ([#47](fffonion/lua-resty-acme#47)) [efb0602](fffonion/lua-resty-acme@efb0602)
- **tls-alpn-01:** set version 3 in certificate generated ([#49](fffonion/lua-resty-acme#49)) [887cad8](fffonion/lua-resty-acme@887cad8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tls-alpn-01 challenge is failing due to wrong certificate version
2 participants