Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #113

Merged
merged 48 commits into from
Nov 6, 2021
Merged

v2.0.0 #113

merged 48 commits into from
Nov 6, 2021

Conversation

fgrehm
Copy link
Owner

@fgrehm fgrehm commented Oct 20, 2021

TL;DR

This is a 8+yr old gem, it's time for a new major release and some breaking changes. We also need to give some love to the UI since it hasn't changed at all since the very first release.

How to test?

Set the gem to the new pre-release version:

gem 'letter_opener_web', '2.0.0.pre.beta'

Then bundle install, restart your app and head over to the app's inbox (ex: http://localhost:3000/inbox) and you'll get the new release 🎉

New look

image

TODO

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #113 (19955da) into master (968d1a0) will increase coverage by 0.36%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   97.31%   97.68%   +0.36%     
==========================================
  Files          23        7      -16     
  Lines         335      302      -33     
==========================================
- Hits          326      295      -31     
+ Misses          9        7       -2     
Impacted Files Coverage Δ
app/models/letter_opener_web/letter.rb 91.89% <90.47%> (-1.10%) ⬇️
...ollers/letter_opener_web/application_controller.rb 100.00% <100.00%> (ø)
...ontrollers/letter_opener_web/letters_controller.rb 96.87% <100.00%> (-3.13%) ⬇️
...llers/letter_opener_web/letters_controller_spec.rb 100.00% <100.00%> (ø)
spec/letter_opener_web_spec.rb 100.00% <100.00%> (ø)
spec/models/letter_opener_web/letter_spec.rb 100.00% <100.00%> (ø)
config/routes.rb
lib/letter_opener_web.rb
lib/letter_opener_web/delivery_method.rb
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19a7f4...19955da. Read the comment docs.

@fgrehm fgrehm marked this pull request as ready for review October 28, 2021 01:28
@tricknotes
Copy link
Contributor

Thanks, @fgrehm for your great work.
I use 2.0.0.pre.alpha1 in my application, and it seems be working fine for me 😄

I'm waiting for a stable release 🚢

@fgrehm
Copy link
Owner Author

fgrehm commented Oct 30, 2021

Thanks @tricknotes! I think we're very close to a final release, there's just one thing @dee-see found that I'd like to do before that 🤞

@ihatov08
Copy link
Contributor

ihatov08 commented Nov 4, 2021

@fgrehm
I used new revision in my sample application(https://github.com/ihatov08/letter_opener_web_rails_api),
csrf error didn't occur.(and flash error didn't occur)
Thank you for fixed errors.
It looks good!

@fgrehm
Copy link
Owner Author

fgrehm commented Nov 6, 2021

Thanks @ihatov08! I'm going to go ahead and cut the final release now 🎉

@fgrehm fgrehm merged commit e277c97 into master Nov 6, 2021
@fgrehm fgrehm deleted the next branch November 6, 2021 14:25
tricknotes added a commit to tricknotes/letter_opener_web that referenced this pull request Nov 11, 2021
This branch was specified as CI target in fgrehm@104bd2f.
However, "next" has been merged into "master" branch in fgrehm#113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants