-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 #113
Conversation
It has been removed from default gems since Ruby 3.0. Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ To use it via bundler, we should specify it as dependency.
…ure / vendoring for assets
… into next Conflicts: app/controllers/letter_opener_web/letters_controller.rb
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 97.31% 97.68% +0.36%
==========================================
Files 23 7 -16
Lines 335 302 -33
==========================================
- Hits 326 295 -31
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
Conflicts: app/views/layouts/letter_opener_web/_javascripts.html.erb
Fix PR number in CHANGELOG
Thanks, @fgrehm for your great work. I'm waiting for a stable release 🚢 |
Thanks @tricknotes! I think we're very close to a final release, there's just one thing @dee-see found that I'd like to do before that 🤞 |
@fgrehm |
Thanks @ihatov08! I'm going to go ahead and cut the final release now 🎉 |
This branch was specified as CI target in fgrehm@104bd2f. However, "next" has been merged into "master" branch in fgrehm#113.
TL;DR
This is a 8+yr old gem, it's time for a new major release and some breaking changes. We also need to give some love to the UI since it hasn't changed at all since the very first release.
How to test?
Set the gem to the new pre-release version:
Then
bundle install
, restart your app and head over to the app's inbox (ex: http://localhost:3000/inbox) and you'll get the new release 🎉New look
TODO
v1-stable
branch with what's on masterLetter
class for avoiding name conflict #108