[add]routes for rails api mode

[ihatov08]

This error occurred when using Rails API mode.

Started POST "/letter_opener/clear" for 172.18.0.1 at 2017-07-25 03:07:35 +0000
ActionController::RoutingError (No route matches [POST] "/letter_opener/clear"):

Plead add this routes.

  post 'clear'                 => 'letters#clear'
  post ':id'                   => 'letters#destroy'

related. #42

[fgrehm]

Hey @ihatov08! Sorry for the long delay here.

I might have a need to use this gem on a side project with Rails API too and I'll give it a shot. I personally think we can just ignore the RESTfulness here. I'm fine with replacing the delete :clear with the post :clear and have an explicit post ':id/delete' just so that we use the same endpoint regardless of Rails API mode or not instead of duplicating the routes.

What do you and @pseudomuto think?

[ihatov08]

@fgrehm
Thank you for your reply!
I think so too.
It is preferable that there is no route to the same endpoint.

LetterOpenerWeb::Engine.routes.draw do
  delete 'clear'                 => 'letters#clear',    :as => :clear_letters
  delete ':id'                   => 'letters#destroy',  :as => :delete_letter
  get    '/'                     => 'letters#index',    :as => :letters
  get    ':id(/:style)'          => 'letters#show',     :as => :letter
  get    ':id/attachments/:file' => 'letters#attachment'
  post   'clear'                 => 'letters#clear' # same endpoint line:2
  post   ':id'                   => 'letters#destroy' # same endpoint line:3
end

It would be nice if the following code works regardless of Rails mode

LetterOpenerWeb::Engine.routes.draw do
  post   'clear'                 => 'letters#clear'
  post   ':id'                   => 'letters#destroy'
  get    '/'                     => 'letters#index',    :as => :letters
  get    ':id(/:style)'          => 'letters#show',     :as => :letter
  get    ':id/attachments/:file' => 'letters#attachment'
end

[tgaff]

Here's my slightly hacky solution: 793b4e8

[fgrehm]

Hey @ihatov08 @tgaff, just a heads up that this is something that will come along with the upcoming 2.0 I got in the works, see the PR linked above for more.

If you have the time, it'd be great if one of you could give that branch a try, tks in advance and sorry for the long delay here!

[fgrehm]

Just got a pre-release ready to go I'll just ping some folks for testing before a final release and this PR should auto close after code is on master.

Thanks for your contribution!

[ihatov08]

@fgrehm

I tried next branch rails api mode.
But error occurred.

https://github.com/ihatov08/letter_opener_web_rails_api

[ihatov08]

@fgrehm

If we want to use letter_opener_web in rails api mode without modifying letter_opener_web, you need the following modifications.

• fix undefined method flash=

ihatov08/letter_opener_web_rails_api@bbfb9a5

• fix csrf error
  ihatov08/letter_opener_web_rails_api@b29af02

[fgrehm]

Hey @ihatov08 , tks for the feedback. I'll take a look at that sample app and see if we can simplify this before final release and / or document how to integrate with rails-api apps

[fgrehm]

Hey @ihatov08, I was not able to figure out why you had issue with flash msgs but the CSRF error should be fixed in 2.0.0.pre.beta with 3b4dc30

Please give that a shot when you get a chance and report back in #113 if things look good to you