Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter by Checkpoint #1014

Closed
dirkmc opened this issue Nov 29, 2022 · 2 comments · Fixed by #1097
Closed

Add filter by Checkpoint #1014

dirkmc opened this issue Nov 29, 2022 · 2 comments · Fixed by #1097
Assignees
Labels

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Nov 29, 2022

Currently it's possible to filter the list of deals by a search query, that matches against peer id, payload cid etc.
However it's not possible to filter by Checkpoint.

We should add an optional parameter to the deals endpoint to allow users to filter by checkpoint:

deals(query: String, checkpoint: String, cursor: ID, offset: Int, limit: Int): DealList!
@jacobheun jacobheun added this to Boost Nov 29, 2022
@jacobheun jacobheun self-assigned this Jan 16, 2023
@jacobheun jacobheun moved this to In Progress in Boost Jan 16, 2023
@jacobheun
Copy link
Contributor

The UI currently shows the 'State' rather than the Checkpoint, so based on a sync discussion we'll aim to expose the ability to filter on State rather than checkpoint. This will also give more granularity for later stages of deals.

@jacobheun
Copy link
Contributor

jacobheun commented Jan 19, 2023

After reviewing the internals of the code here, State is a computed property so for simplicity of this filtering by Checkpoint is the most direct path. Pulling some feedback from slack some requests to be able to filter by are:

  • Filter all deals that are currently transferring, or waiting for offline import
  • Filter for all deals that have been Accepted (and that are offline deals)
  • "basically I want a script that does two things:"
    • give me the list of transfers in 'Transfer Queued' state for a particular client
    • restart those transfers the same way as the web UI would

I'm reviewing the UX for the api and UI and will update when I have more thoughts on best path forward for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants