-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to filter certain properties in the deal list #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Jan 19, 2023
jacobheun
force-pushed
the
feat/checkpoint-filter
branch
2 times, most recently
from
January 23, 2023 14:21
ba29deb
to
bb0e9d9
Compare
dirkmc
reviewed
Jan 23, 2023
jacobheun
force-pushed
the
feat/checkpoint-filter
branch
from
January 24, 2023 13:33
32c7abc
to
52546b4
Compare
This adds the ability to pass a filter, for limited properties, to the deal list and count functions. This still needs to be properly exposed on the graphql resolver.
Currently checkpoint is mandatory, this needs to be made optional
This could use click away close detection
jacobheun
force-pushed
the
feat/checkpoint-filter
branch
from
January 25, 2023 16:00
52546b4
to
a723dd1
Compare
dirkmc
reviewed
Jan 26, 2023
dirkmc
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🙌
Just one nit to fix and then feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the ability to include filters when search for deals in addition to the existing query functionality. This should address all scenarios mentioned in #1014.
Example curls:
Get all offline deals pending transfer
Get all deals currently in the sealing pipeline
Current Supported Properties
I've started with a subset of properties to filter by based on common scenarios. VerifiedDeal may be less useful atm, but there may be some useful applications there outside of the requested scenarios.
Work remaining
Disclaimer: Still getting up to speed on go, so please suggest more idiomatic usage where applicable.
Resolves #1014
Demos
Querying with filters via the GQL UI
20230124141720545.mp4
Querying with filters via the Web UI
20230125195402736_record.mp4