feat: add support for Non-interactive PoRep #453
Conversation
|
This needs to be rebased on top of #450, not master |
|
Also rebased on your branch. |
cryptonemo
force-pushed
the
improved-error-handling
branch
from
98638f2 to
80ff911
Compare
|
I've rebased this PR and also adapted it to the fixed names. |
|
I think this needs to target |
Yeah, that is correct. That branch was based off master today, so it should not cause any issues. |
|
I've changed the base to |
This commit adds support for ni-porep. It also makes CI match the Rust version in the rust-toolchain.toml
|
Just going through and looking at nv23-related open items. A few questions:
|
Make CI pass again. This reverts commit 896d156.
In the past did the FilCrypto team the Rust side of things and then the Lotus team added the Go parts and merged it.
The Go parts which are done at #456
For the Rust side of things, Elliptic Research, for the Go side I'd guess FilOz.
I've pushed a new commit which should get things green. |
|
I should've added that in the past the Go side (Lotus team) owned the merging of things of the FFI, the FilCrypto team was just contributing to the Rust side of things (@cryptonemo please correct me if I'm wrong). |
There was a problem hiding this comment.
this all seems good to me
although, I think we need to update feat/nv23 with the circle config for macos builders so we can get rid of it from this PR @rjan90
@vmx I think you could pull in the Rust changes from #456 into this PR, I included seal_commit_phase2_circuit_proofs there but it seems more appropriate coming from you.
|
@vmx : thanks for the explanation on how the filecoin-ffi work has been traditionally handled. I expect some of that may need to be reevaluated or at least documented in light of groups like FilOz and Elliptic Research being separate companies now, but that can be thought through and handled later. For now, given this just has the rust changes and Elliptic Research is the owner of those, I've assigned this issue to you. Please go ahead and merge when you have approval (✅ here) and all the rust changes are included. (It sounds like per Rod there is a small change to bring over.) |
This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458.
This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458.
|
I'm closing given superseded by #459 |
* feat: add support for Non-interactive PoRep This commit adds support for ni-porep. It's a combination of the indivdual PRs #453, #456 and #458. Thanks everyone involved working on those. The changes are for the Go side (actors and FVM) as well as the Rust side (proofs API). Changes on the CI are: - Makes it match the Rust version in the rust-toolchain.toml - Newer Go version (1.21) on all platforms - Larger instance for the testsas the Ni-PoRep synthesis phase takes more resources. Closes #453, #456, #458. --------- Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: nemo <nemo@ellipticresearch.com>
This commit adds support for ni-porep.
Also Rust >= 1.70 is needed due to the dependency on
homev0.5.9 and fix the corresponding new Clippy warnings.This is only the Rust side of things, the Go parts are missing.